Adds frame seeking hotkeys #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidXenakis
force-pushed
the
master
branch
3 times, most recently
from
b344d48 to
6d5f0e2
Compare
Also, refactor the method for finding the right timestamp to start/end at when a trim exists. The new method uses a binary search, so it should be more efficient than a linear seek. I use this method to wrap around in the frame seeking. Tested using trimmed videos at different speeds, and everything works as expected. Updated Readme with new hotkeys
|
@exeldro Could you please take a look? This is a killer feature for my use-case! |
|
At first glance it looks good. I plan on taking a good look this week. |
exeldro
requested changes
Jan 30, 2024
|
With my latest changes, I've addressed your comments, added localization text, and added a feature to allow a coarse grained frame step, which defaults to 5 frames. This allows me to, for instance, hold shift when stepping frames to step a larger amount. |
|
I will do some fixes on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, refactor the method for finding the right timestamp to start/end at when a trim exists. The new method uses a binary search, so it should be more efficient than a linear seek. I use this method to wrap around in the frame seeking.
Tested using trimmed videos at different speeds, and everything works as expected.
Updated Readme with new hotkeys